Skip to content

Delete flutter/ directories that no longer serve a purpose.#2052

Merged
kenzieschmoll merged 7 commits intoflutter:masterfrom
kenzieschmoll:cleanup
Jun 8, 2020
Merged

Delete flutter/ directories that no longer serve a purpose.#2052
kenzieschmoll merged 7 commits intoflutter:masterfrom
kenzieschmoll:cleanup

Conversation

@kenzieschmoll
Copy link
Copy Markdown
Member

@kenzieschmoll kenzieschmoll commented Jun 8, 2020

This CL moves all files inside of a flutter/ dir up one level to the parent dir, and deletes all flutter/ directories.

We originally placed all flutter files inside of a flutter/ dir to split the flutter and html builds. Now that the html app is deleted, we no longer need these directories.

@jacob314
Copy link
Copy Markdown
Contributor

jacob314 commented Jun 8, 2020

This will create a lot of pain for pending CLs. do we have any pending CLs we want to land before this goes in? I've got one but I can deal with the pain if it is the only major CL.

@kenzieschmoll
Copy link
Copy Markdown
Member Author

I didn't see any large CLs under review. Last time I mentioned this, we discussed waiting for Terry's memory CL to land and the table CLs Devon had in progress. The pending PRs under review seem relatively small.

@kenzieschmoll
Copy link
Copy Markdown
Member Author

kenzieschmoll commented Jun 8, 2020

@jacob314 I want to verify with you that the file move for rendering_tester is okay
devtools_app/test/flutter/rendering_tester.dart → devtools_app/test/support/rendering_tester.dart

When I moved the contents of test/flutter to test/, travis was trying to run rendering_tester.dart as a test, which it is not. Looks like you added this as part of the extent_delegate_test code.

# so we explicitly provide them.
if [ "$PLATFORM" = "vm" ]; then
flutter test test/*.dart test/{core,fixtures,flutter,support,ui}/
flutter test test/*.dart test/{core,fixtures,support,ui}/
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacob314 Please review the changes in this file

Copy link
Copy Markdown
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenzieschmoll kenzieschmoll merged commit 8204794 into flutter:master Jun 8, 2020
@kenzieschmoll kenzieschmoll deleted the cleanup branch June 8, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants